Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-12635 sc-12634 yaml reference encoding #12

Merged
merged 18 commits into from
Apr 17, 2024

Conversation

mattwwarren
Copy link
Collaborator

maybe sketchy testing but the fixes are solid

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.08%. Comparing base (ba791f3) to head (3ab8a95).

Files Patch % Lines
src/dynamic_importer/processors/yaml.py 88.23% 2 Missing ⚠️
src/dynamic_importer/api/types.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   88.02%   88.08%   +0.06%     
==========================================
  Files          11       12       +1     
  Lines         693      722      +29     
==========================================
+ Hits          610      636      +26     
- Misses         83       86       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattwwarren mattwwarren merged commit 41d1ec4 into main Apr 17, 2024
3 checks passed
@mattwwarren mattwwarren deleted the sc-12635/sc-12634/yaml-reference-encoding branch April 17, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants