Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Commit

Permalink
Remove some empty log messages when running rcedit
Browse files Browse the repository at this point in the history
  • Loading branch information
caesay committed Apr 22, 2022
1 parent 5cb8fdd commit 4375875
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions src/Squirrel/Internal/HelperExe.cs
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ public static async Task CompileWixTemplateToMsi(string wxsTarget, string output
var msg = String.Format(
"Failed to compile WiX template, command invoked was: '{0} {1}'\n\nOutput was:\n{2}",
"candle.exe", Utility.ArgsToCommandLine(candleParams), processResult.Item2);

throw new Exception(msg);
}

Expand All @@ -110,7 +109,6 @@ public static async Task CompileWixTemplateToMsi(string wxsTarget, string output
var msg = String.Format(
"Failed to link WiX template, command invoked was: '{0} {1}'\n\nOutput was:\n{2}",
"light.exe", Utility.ArgsToCommandLine(lightParams), processResult.Item2);

throw new Exception(msg);
}
} finally {
Expand All @@ -122,15 +120,11 @@ public static async Task SetExeIcon(string exePath, string iconPath)
{
var args = new[] { Path.GetFullPath(exePath), "--set-icon", iconPath };
var processResult = await Utility.InvokeProcessAsync(RceditPath, args, CancellationToken.None).ConfigureAwait(false);

if (processResult.ExitCode != 0) {
var msg = String.Format(
"Failed to modify resources, command invoked was: '{0} {1}'\n\nOutput was:\n{2}",
RceditPath, args, processResult.StdOutput);

throw new Exception(msg);
} else {
Console.WriteLine(processResult.StdOutput);
}
}

Expand All @@ -154,15 +148,11 @@ public static async Task SetPEVersionBlockFromPackageInfo(string exePath, NuGet.
}

var processResult = await Utility.InvokeProcessAsync(RceditPath, args, CancellationToken.None).ConfigureAwait(false);

if (processResult.ExitCode != 0) {
var msg = String.Format(
"Failed to modify resources, command invoked was: '{0} {1}'\n\nOutput was:\n{2}",
RceditPath, args, processResult.StdOutput);

throw new Exception(msg);
} else {
Console.WriteLine(processResult.StdOutput);
}
}
}
Expand Down

0 comments on commit 4375875

Please sign in to comment.