Add tests for dots and dashes in package name

clowd · Jan 10, 2022 · cf740c5 · cf740c5
1 parent b160e99
commit cf740c5
Show file tree

Hide file tree

Showing 3 changed files with 78 additions and 0 deletions.
diff --git a/test/ApplyReleasesTests.cs b/test/ApplyReleasesTests.cs
@@ -176,6 +176,50 @@ public async Task FullUninstallRemovesAllVersions()
             }
         }
 
+        [Fact]
+        public async Task CanInstallAndUpdatePackageWithDotsInId()
+        {
+            string tempDir;
+            string remotePkgDir;
+            const string pkgName = "Squirrel.Installed.App";
+
+            using (Utility.WithTempDirectory(out tempDir))
+            using (Utility.WithTempDirectory(out remotePkgDir)) {
+                // install 0.1.0
+                IntegrationTestHelper.CreateFakeInstalledApp("0.1.0", remotePkgDir, "SquirrelInstalledAppWithDots.nuspec");
+                var pkgs = ReleaseEntry.BuildReleasesFile(remotePkgDir);
+                ReleaseEntry.WriteReleaseFile(pkgs, Path.Combine(remotePkgDir, "RELEASES"));
+
+                using (var fixture = new UpdateManager(remotePkgDir, pkgName, tempDir)) {
+                    await fixture.FullInstall();
+                }
+
+                Assert.True(Directory.Exists(Path.Combine(tempDir, pkgName, "app-0.1.0")));
+                await Task.Delay(1000);
+
+                // update top 0.2.0
+                IntegrationTestHelper.CreateFakeInstalledApp("0.2.0", remotePkgDir, "SquirrelInstalledAppWithDots.nuspec");
+                pkgs = ReleaseEntry.BuildReleasesFile(remotePkgDir);
+                ReleaseEntry.WriteReleaseFile(pkgs, Path.Combine(remotePkgDir, "RELEASES"));
+
+                using (var fixture = new UpdateManager(remotePkgDir, pkgName, tempDir)) {
+                    await fixture.UpdateApp();
+                }
+
+                Assert.True(Directory.Exists(Path.Combine(tempDir, pkgName, "app-0.2.0")));
+                await Task.Delay(1000);
+
+                // uninstall
+                using (var fixture = new UpdateManager(remotePkgDir, pkgName, tempDir)) {
+                    await fixture.FullUninstall();
+                }
+
+                Assert.False(File.Exists(Path.Combine(tempDir, pkgName, "app-0.1.0", "args.txt")));
+                Assert.False(File.Exists(Path.Combine(tempDir, pkgName, "app-0.2.0", "args.txt")));
+                Assert.True(File.Exists(Path.Combine(tempDir, pkgName, ".dead")));
+            }
+        }
+
         [Fact]
         public void WhenNoNewReleasesAreAvailableTheListIsEmpty()
         {

diff --git a/test/ReleaseEntryTests.cs b/test/ReleaseEntryTests.cs
@@ -27,6 +27,26 @@ public void ParseValidReleaseEntryLines(string releaseEntry, string fileName, lo
             Assert.Equal(query, fixture.Query);
         }
 
+        [Theory]
+        [InlineData(@"94689fede03fed7ab59c24337673a27837f0c3ec My.Cool.App-1.0-full.nupkg 1004502", "My.Cool.App")]
+        [InlineData(@"94689fede03fed7ab59c24337673a27837f0c3ec   My.Cool.App-1.1.nupkg 1004502", "My.Cool.App")]
+        [InlineData(@"94689fede03fed7ab59c24337673a27837f0c3ec  http://test.org/Folder/My.Cool.App-1.2.nupkg?query=param     1231953", "My.Cool.App")]
+        public void ParseValidReleaseEntryLinesWithDots(string releaseEntry, string packageName)
+        {
+            var fixture = ReleaseEntry.ParseReleaseEntry(releaseEntry);
+            Assert.Equal(packageName, fixture.PackageName);
+        }
+
+        [Theory]
+        [InlineData(@"94689fede03fed7ab59c24337673a27837f0c3ec My-Cool-App-1.0-full.nupkg 1004502", "My-Cool-App")]
+        [InlineData(@"94689fede03fed7ab59c24337673a27837f0c3ec   My-Cool-App-1.1.nupkg 1004502", "My-Cool-App")]
+        [InlineData(@"94689fede03fed7ab59c24337673a27837f0c3ec  http://test.org/Folder/My-Cool-App-1.2.nupkg?query=param     1231953", "My-Cool-App")]
+        public void ParseValidReleaseEntryLinesWithDashes(string releaseEntry, string packageName)
+        {
+            var fixture = ReleaseEntry.ParseReleaseEntry(releaseEntry);
+            Assert.Equal(packageName, fixture.PackageName);
+        }
+
         [Theory]
         [InlineData(@"0000000000000000000000000000000000000000  file:/C/Folder/MyCoolApp-0.0.nupkg  0")]
         [InlineData(@"0000000000000000000000000000000000000000  C:\Folder\MyCoolApp-0.0.nupkg  0")]

diff --git a/test/fixtures/SquirrelInstalledAppWithDots.nuspec b/test/fixtures/SquirrelInstalledAppWithDots.nuspec
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8"?>
+<package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
+    <metadata>
+        <id>Squirrel.Installed.App</id>
+        <version>0.1.0</version>
+        <authors>Anaïs Betts</authors>
+        <requireLicenseAcceptance>false</requireLicenseAcceptance>
+        <description>My package description.</description>
+    </metadata>
+    <files>
+        <file src="NotSquirrelAwareApp.exe" target="lib\net45\NotSquirrelAwareApp.exe" />
+        <file src="SquirrelAwareApp.exe" target="lib\net45\SquirrelAwareApp.exe" />
+    </files>
+</package>