Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Is it a big change to add older vcredist runtimes, like VS2013? #30

Closed
theresia-tobii opened this issue Jan 13, 2022 · 5 comments
Closed
Labels
enhancement New feature or request

Comments

@theresia-tobii
Copy link

theresia-tobii commented Jan 13, 2022

Which we unfortunately have a third party dependency on for one of our applications.

I could even try my hand at a PR if you want.

@caesay
Copy link
Member

caesay commented Jan 13, 2022

It's not a huge change, I'd be happy for you send a pull request if you are interested!

The redist for 2015-2022 is all at the same download url and is fully backwards compatible. When installing, if your required version is more recent than the currently installed version, we just always install the latest version.

To support older versions, we will need to allow different download URL's to be provided. This could be done by providing a new constructor in VCRedistInfo, allowing a download url to be supplied (for both x86 and x64). An alternative (possibly cleaner way) would be to create a new class LegacyVCRedistInfo which derives from VCRedistInfo and just overrides the GetDownloadUrl method.

You can find the details of the 2015-2022 behavior, as well as the download links and current versions for older redists at this link: https://docs.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist?view=msvc-170#visual-studio-2015-2017-2019-and-2022

@caesay caesay added the enhancement New feature or request label Jan 13, 2022
@caesay
Copy link
Member

caesay commented Jan 13, 2022

You may also want to override the InvokeInstaller function, if installing very old runtimes, if the supported arguments have changed. You can usually check for supported command line arguments by doing vcredist.exe -h

@theresia-tobii
Copy link
Author

Ok, I will give it a go this weekend.

caesay added a commit that referenced this issue Jan 17, 2022
@caesay
Copy link
Member

caesay commented Jan 17, 2022

I have added 2010-2013, if you need anything other than that feel free to send a PR

@caesay caesay closed this as completed Jan 17, 2022
@caesay
Copy link
Member

caesay commented Jan 17, 2022

This is now released in 2.7.79.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants