p1: support custom promise API

Signed-off-by: Alex Chi <[email protected]>
cmu-db · Sep 9, 2023 · 558030f · 558030f
1 parent 03b9be6
commit 558030f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/include/storage/disk/disk_scheduler.h b/src/include/storage/disk/disk_scheduler.h
@@ -73,6 +73,16 @@ class DiskScheduler {
    */
   void StartWorkerThread();
 
+  using DiskSchedulerPromise = std::promise<bool>;
+
+  /**
+   * @brief Create a Promise object. If you want to implement your own version of promise, you can change this function
+   * so that our test cases can use your promise implementation.
+   *
+   * @return std::promise<bool>
+   */
+  auto CreatePromise() -> DiskSchedulerPromise { return {}; };
+
  private:
   /** Pointer to the disk manager. */
   DiskManager *disk_manager_ __attribute__((__unused__));

diff --git a/test/storage/disk_scheduler_test.cpp b/test/storage/disk_scheduler_test.cpp
@@ -33,9 +33,9 @@ TEST(DiskSchedulerTest, DISABLED_ScheduleWriteReadPageTest) {
 
   std::strncpy(data, "A test string.", sizeof(data));
 
-  std::promise<bool> promise1;
+  auto promise1 = disk_scheduler->CreatePromise();
   auto future1 = promise1.get_future();
-  std::promise<bool> promise2;
+  auto promise2 = disk_scheduler->CreatePromise();
   auto future2 = promise2.get_future();
 
   disk_scheduler->Schedule({/*is_write=*/true, reinterpret_cast<char *>(&data), /*page_id=*/0, promise1});