fix: fix page guard sample test (#695)

* fix page guard sample test * add upgraderead & upgradewrite method
cmu-db · Jan 30, 2024 · bd62db0 · bd62db0
1 parent b6cc751
commit bd62db0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/storage/page/page_guard.cpp b/src/storage/page/page_guard.cpp
@@ -11,6 +11,10 @@ auto BasicPageGuard::operator=(BasicPageGuard &&that) noexcept -> BasicPageGuard
 
 BasicPageGuard::~BasicPageGuard(){};  // NOLINT
 
+auto BasicPageGuard::UpgradeRead() -> ReadPageGuard { return {bpm_, page_}; }
+
+auto BasicPageGuard::UpgradeWrite() -> WritePageGuard { return {bpm_, page_}; }
+
 ReadPageGuard::ReadPageGuard(BufferPoolManager *bpm, Page *page) {}
 
 ReadPageGuard::ReadPageGuard(ReadPageGuard &&that) noexcept = default;

diff --git a/test/storage/page_guard_test.cpp b/test/storage/page_guard_test.cpp
@@ -45,7 +45,6 @@ TEST(PageGuardTest, DISABLED_SampleTest) {
 
   {
     auto *page2 = bpm->NewPage(&page_id_temp);
-    page2->RLatch();
     auto guard2 = ReadPageGuard(bpm.get(), page2);
   }