Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p0: add new tests + upgrade dependencies #593

Merged
merged 3 commits into from
Aug 26, 2023
Merged

p0: add new tests + upgrade dependencies #593

merged 3 commits into from
Aug 26, 2023

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Aug 14, 2023

also upgrade to C++ 23 so that we can use std::backtrace

@skyzh skyzh requested a review from yliang412 August 14, 2023 18:18
@skyzh
Copy link
Member Author

skyzh commented Aug 14, 2023

need to revert to C++23 change 🤣

Copy link
Member

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does changing to C++23 break other part of the codebase?

@xzhseh
Copy link
Contributor

xzhseh commented Aug 17, 2023

Should we also manually add -std=c++23 flag in CMakeLists.txt🤔

@skyzh
Copy link
Member Author

skyzh commented Aug 24, 2023

decided to drop C++23 for this semester and bumped several dependencies, PTAL again, thanks! @yliang412

@skyzh skyzh changed the title p0: add new tests p0: add new tests + upgrade dependencies Aug 24, 2023
Copy link
Member

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

github-actions bot and others added 3 commits August 26, 2023 15:23
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh merged commit ac25e57 into master Aug 26, 2023
3 checks passed
@skyzh skyzh deleted the skyzh/p0-new-tests branch August 26, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants