Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disk scheduler to P1 #602

Merged
merged 4 commits into from
Sep 3, 2023
Merged

Add disk scheduler to P1 #602

merged 4 commits into from
Sep 3, 2023

Conversation

fernandolis10
Copy link
Contributor

DO NOT PUSH PROJECT SOLUTIONS PUBLICLY.

And especially do NOT open pull requests with project solutions!

Please be considerate of this free educational resource.

skyzh
skyzh approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and we can add some public tests for disk scheduler in another PR :)

@fernandolis10 fernandolis10 merged commit 4a04c19 into master Sep 3, 2023
3 checks passed
@fernandolis10 fernandolis10 deleted the 2023-p1-disk-scheduler-public branch September 3, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernandolis10 @skyzh