Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPP Standards #726

Merged
merged 6 commits into from
Aug 22, 2024
Merged

CPP Standards #726

merged 6 commits into from
Aug 22, 2024

Conversation

prashanthduvvada
Copy link
Contributor

@prashanthduvvada prashanthduvvada commented Aug 21, 2024 •
edited
Loading

Changing from std::string to std::filesystem::path & BustubInstance to BusTubInstance

@prashanthduvvada prashanthduvvada changed the title std::string to std::filesystem::path CPP Standards Aug 21, 2024
@prashanthduvvada prashanthduvvada linked an issue Aug 21, 2024 that may be closed by this pull request
Use std::filesystem::path instead of strings #724
Closed
connortsui20
connortsui20 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@connortsui20 connortsui20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however we should probably rebase this so it's not dependent on #725. Or we can just merge #725 first.

@prashanthduvvada prashanthduvvada merged commit 5545dbf into master Aug 22, 2024
4 checks passed
@prashanthduvvada prashanthduvvada deleted the cpp-standards-2 branch August 22, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connortsui20 connortsui20 connortsui20 approved these changes

@apavlo apavlo Awaiting requested review from apavlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use std::filesystem::path instead of strings
2 participants
@prashanthduvvada @connortsui20