Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0 Starter Code #729

Merged
merged 7 commits into from
Aug 26, 2024
Merged

P0 Starter Code #729

merged 7 commits into from
Aug 26, 2024

Conversation

prashanthduvvada
Copy link
Contributor

Starter Code for P0.

Copy link

@cjtsui cjtsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if the doc comments had proper capitalization and punctuation, but other than that lgtm

Copy link
Member

@connortsui20 connortsui20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops wrong account

@prashanthduvvada prashanthduvvada merged commit 0d4e3f8 into master Aug 26, 2024
4 checks passed
@tre3p
Copy link

tre3p commented Aug 27, 2024

@prashanthduvvada maybe you can also add examples of cardinality calculations on the primer page? Cause you have examples of how data is laid out, but not how cardinality is calculated then based on this data. Thx in advance!

@prashanthduvvada
Copy link
Contributor Author

Okay ..that should fix most confusions. I was thinking about the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants