Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hanging #59

Closed
cnguy opened this issue Dec 21, 2018 · 1 comment
Closed

Hanging #59

cnguy opened this issue Dec 21, 2018 · 1 comment

Comments

@cnguy
Copy link
Owner

cnguy commented Dec 21, 2018 •
edited
Loading

setInterval and setTimeouts stall out the process (but are harmless). A developer can use unref to make the process exit if there are no more events besides the interval/timeouts.

Colorfulstan/RiotRateLimiter-node@154eb8a

this works (thanks to https://github.com/MingweiSamuel), and is testable in

https://github.com/cnguy/kayn/tree/with-unref-changes

Will probably be released (using my temporary rate limiter fork) in the next version along with the Tournament stuffs + TS bindings

How to reproduce

Just make a request in some random index.js file, the process will harmlessly hang.

await kayn.SummonerV4.by.name('Contractz')
// process will not exit
cnguy added a commit that referenced this issue Jan 4, 2019
@cnguy
fix (Rate-limiter): Upgrade riot-ratelimiter-temp to address hanging #59
e743a83
@cnguy
Copy link
Owner Author

cnguy commented Jan 4, 2019

Released in v0.9.4! Process now exits properly.

@cnguy cnguy closed this as completed Jan 4, 2019
@cnguy cnguy mentioned this issue Jan 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cnguy