Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: binary path #381

Merged
merged 1 commit into from
Jan 28, 2023
Merged

fix: binary path #381

merged 1 commit into from
Jan 28, 2023

Conversation

elrrrrrrr
Copy link
Member

目前逻辑会解析出 https://skia-canvas.s3.us-east-1.amazonaws.com/v0.9.24/linux-arm64-{node_napi_label}.tar.gz 会导致任务多次失败重试

  • 添加 if/else 判断兼容 {platform}-{arch}-{node_napi_label}
  • 临时兼容,后续通过变量替换实现

@elrrrrrrr elrrrrrrr added the bug Something isn't working label Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #381 (0be5a2e) into master (dd4fe23) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
- Coverage   97.61%   97.43%   -0.18%     
==========================================
  Files         152      152              
  Lines       12946    12982      +36     
  Branches     1686     1684       -2     
==========================================
+ Hits        12637    12649      +12     
- Misses        309      333      +24     
Impacted Files Coverage Δ
app/common/adapter/binary/NodePreGypBinary.ts 100.00% <100.00%> (ø)
config/config.default.ts 87.28% <0.00%> (-8.68%) ⬇️
app/infra/NFSClientAdapter.ts 86.58% <0.00%> (-8.54%) ⬇️
app/core/service/TaskService.ts 97.77% <0.00%> (-1.67%) ⬇️
app/core/service/PackageManagerService.ts 97.64% <0.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fengmk2 fengmk2 merged commit 790621b into master Jan 28, 2023
@fengmk2 fengmk2 deleted the fix-binary-path branch January 28, 2023 03:25
fengmk2 pushed a commit that referenced this pull request Jan 28, 2023
[skip ci]

## [3.1.2](v3.1.1...v3.1.2) (2023-01-28)

### Bug Fixes

* binary path ([#381](#381)) ([790621b](790621b))
@github-actions
Copy link

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants