Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config path #385

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix: config path #385

merged 1 commit into from
Jan 30, 2023

Conversation

elrrrrrrr
Copy link
Member

Fix partial config/binaries file path in binary.
Prevent js parsing issues when cnpmcore is required as an npm module.
This is the part that was missed in the previous pr . #384

@elrrrrrrr elrrrrrrr added the bug Something isn't working label Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #385 (dbd5043) into master (0cc348d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   97.47%   97.45%   -0.02%     
==========================================
  Files         151      152       +1     
  Lines       12918    13097     +179     
  Branches     1681     1689       +8     
==========================================
+ Hits        12592    12764     +172     
- Misses        326      333       +7     
Impacted Files Coverage Δ
app/common/adapter/binary/AbstractBinary.ts 94.00% <100.00%> (+0.06%) ⬆️
app/common/adapter/binary/ApiBinary.ts 90.90% <100.00%> (+0.58%) ⬆️
app/common/adapter/binary/BucketBinary.ts 100.00% <100.00%> (ø)
app/common/adapter/binary/CypressBinary.ts 100.00% <100.00%> (ø)
app/common/adapter/binary/ElectronBinary.ts 100.00% <100.00%> (ø)
app/common/adapter/binary/GithubBinary.ts 92.15% <100.00%> (+0.49%) ⬆️
app/common/adapter/binary/ImageminBinary.ts 100.00% <100.00%> (ø)
app/common/adapter/binary/NodeBinary.ts 100.00% <100.00%> (ø)
app/common/adapter/binary/NodePreGypBinary.ts 100.00% <100.00%> (ø)
app/common/adapter/binary/NwjsBinary.ts 100.00% <100.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit ab72a3b into master Jan 30, 2023
@killagu killagu deleted the fix-config-path branch January 30, 2023 02:17
fengmk2 pushed a commit that referenced this pull request Jan 30, 2023
[skip ci]

## [3.2.3](v3.2.2...v3.2.3) (2023-01-30)

### Bug Fixes

* config path ([#385](#385)) ([ab72a3b](ab72a3b))
@github-actions
Copy link

🎉 This PR is included in version 3.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants