fix: should init binary adapter before reuse it #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
commented
Feb 5, 2023
Closed
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 97.59% 97.41% -0.18%
==========================================
Files 152 152
Lines 13139 13193 +54
Branches 1698 1705 +7
==========================================
+ Hits 12823 12852 +29
- Misses 316 341 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
elrrrrrrr
reviewed
Feb 5, 2023
fengmk2
commented
Feb 5, 2023
elrrrrrrr
reviewed
Feb 5, 2023
fengmk2
pushed a commit
that referenced
this pull request
Feb 5, 2023
[skip ci] ## [3.2.6](v3.2.5...v3.2.6) (2023-02-05) ### Bug Fixes * should init binary adapter before reuse it ([#393](#393)) ([b9985ab](b9985ab))
|
🎉 This PR is included in version 3.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fengmk2
commented
May 25, 2023
| } | ||
| return await this.eggObjectFactory.getEggObject(AbstractBinary, binaryConfig.type); | ||
| await binaryAdapter.init(binaryName); |
There was a problem hiding this comment.
SingletonProto 有一个 init 方法约定，正好冲突了，我改改
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.