-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: should init binary adapter before reuse it #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 97.59% 97.41% -0.18%
==========================================
Files 152 152
Lines 13139 13193 +54
Branches 1698 1705 +7
==========================================
+ Hits 12823 12852 +29
- Misses 316 341 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
[skip ci] ## [3.2.6](v3.2.5...v3.2.6) (2023-02-05) ### Bug Fixes * should init binary adapter before reuse it ([#393](#393)) ([b9985ab](b9985ab))
🎉 This PR is included in version 3.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
} | ||
return await this.eggObjectFactory.getEggObject(AbstractBinary, binaryConfig.type); | ||
await binaryAdapter.init(binaryName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SingletonProto 有一个 init 方法约定,正好冲突了,我改改
No description provided.