Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should sync package deps by default #400

Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix: should sync package deps by default #400

merged 1 commit into from
Feb 10, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Feb 9, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #400 (c2fd4b8) into master (07a19cf) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   97.47%   97.41%   -0.07%     
==========================================
  Files         152      152              
  Lines       13197    13197              
  Branches     1704     1707       +3     
==========================================
- Hits        12864    12856       -8     
- Misses        333      341       +8
Impacted Files Coverage Δ
app/common/adapter/NPMRegistry.ts 100.00% <100.00%> (ø)
config/config.default.ts 87.50% <0.00%> (-8.53%) ⬇️
app/core/service/TaskService.ts 97.77% <0.00%> (-1.12%) ⬇️
app/port/controller/PackageSyncController.ts 100.00% <0.00%> (+1.42%) ⬆️
app/port/controller/BinarySyncController.ts 96.92% <0.00%> (+2.30%) ⬆️
app/infra/NFSClientAdapter.ts 86.58% <0.00%> (+3.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fengmk2 fengmk2 merged commit 282abf6 into master Feb 10, 2023
@fengmk2 fengmk2 deleted the sync-deps-by-default branch February 10, 2023 00:50
fengmk2 pushed a commit that referenced this pull request Feb 10, 2023
@semantic-release-bot
Release 3.3.1
2c679be 
[skip ci]

## [3.3.1](v3.3.0...v3.3.1) (2023-02-10)

### Bug Fixes

* should sync package deps by default ([#400](#400)) ([282abf6](282abf6))
@github-actions
Copy link

🎉 This PR is included in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

fengmk2 added a commit that referenced this pull request Feb 10, 2023
@fengmk2
Revert "fix: should sync package deps by default (#400)"
15ba5c1 
This reverts commit 282abf6.
fengmk2 added a commit that referenced this pull request Feb 10, 2023
@fengmk2
Revert "fix: should sync package deps by default (#400)" (#401)
b021e1e 
This reverts commit 282abf6.
fengmk2 pushed a commit that referenced this pull request Feb 10, 2023
@semantic-release-bot
Release 3.3.2
18cfb0d 
[skip ci]

## [3.3.2](v3.3.1...v3.3.2) (2023-02-10)

### Reverts

* Revert "fix: should sync package deps by default (#400)" (#401) ([b021e1e](b021e1e)), closes [#400](#400) [#401](#401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fengmk2