Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow OPTIONS request on tgz downlaod url #605

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Nov 3, 2023

make webcontainer can run npm install on cnpmcore registry

make webcontainer can run npm install on cnpmcore registry
@fengmk2 fengmk2 added the enhancement New feature or request label Nov 3, 2023
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #605 (91ff68d) into master (ab2fde7) will decrease coverage by 0.16%.
Report is 64 commits behind head on master.
The diff coverage is 95.48%.

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   97.02%   96.87%   -0.16%     
==========================================
  Files         174      180       +6     
  Lines       16588    17517     +929     
  Branches     2177     2276      +99     
==========================================
+ Hits        16095    16969     +874     
- Misses        493      548      +55     
Files Coverage Δ
app/common/FileUtil.ts 100.00% <100.00%> (ø)
app/common/UserUtil.ts 100.00% <100.00%> (ø)
app/common/adapter/CacheAdapter.ts 100.00% <100.00%> (ø)
app/common/adapter/NPMRegistry.ts 100.00% <100.00%> (ø)
app/common/adapter/binary/AbstractBinary.ts 94.17% <100.00%> (+0.11%) ⬆️
...pp/common/adapter/binary/ChromeForTestingBinary.ts 100.00% <100.00%> (+2.89%) ⬆️
app/common/adapter/binary/NodePreGypBinary.ts 98.69% <100.00%> (+<0.01%) ⬆️
app/common/adapter/binary/PlaywrightBinary.ts 99.26% <100.00%> (+0.03%) ⬆️
...on/adapter/changesStream/CnpmjsorgChangesStream.ts 100.00% <100.00%> (ø)
app/common/constants.ts 100.00% <100.00%> (ø)
... and 50 more

... and 2 files with indirect coverage changes

@fengmk2 fengmk2 merged commit 5bedb25 into master Nov 3, 2023
10 of 12 checks passed
@fengmk2 fengmk2 deleted the support-tgz-options-request branch November 3, 2023 10:22
fengmk2 pushed a commit that referenced this pull request Nov 3, 2023
[skip ci]

## [3.48.0](v3.47.2...v3.48.0) (2023-11-03)

### Features

* allow OPTIONS request on tgz downlaod url ([#605](#605)) ([5bedb25](5bedb25))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants