Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: es query script score syntax fix and add error handler for 404 error #607

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: es query script score syntax fix and add error handler for 404 error #607

merged 1 commit into from
Nov 6, 2023

Conversation

Beace
Copy link
Contributor

@Beace Beace commented Nov 3, 2023

fixed #598

@Beace Beace assigned fengmk2 and elrrrrrrr and unassigned fengmk2 and elrrrrrrr Nov 3, 2023
fengmk2
fengmk2 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fengmk2
Copy link
Member

fengmk2 commented Nov 3, 2023

ci 修复一下

@fengmk2 fengmk2 added the bug Something isn't working label Nov 3, 2023
@fengmk2 fengmk2 changed the title fix: fix es script score syntax query and add error handler for 404 error fix: es query script score syntax fix and add error handler for 404 error Nov 3, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited
Loading

Codecov Report

Merging #607 (e1df98c) into master (ab2fde7) will decrease coverage by 0.16%.
Report is 70 commits behind head on master.
The diff coverage is 95.48%.

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
- Coverage   97.02%   96.86%   -0.16%     
==========================================
  Files         174      180       +6     
  Lines       16588    17530     +942     
  Branches     2177     2280     +103     
==========================================
+ Hits        16095    16981     +886     
- Misses        493      549      +56
Files Coverage Δ
app/common/FileUtil.ts 100.00% <100.00%> (ø)
app/common/UserUtil.ts 100.00% <100.00%> (ø)
app/common/adapter/CacheAdapter.ts 100.00% <100.00%> (ø)
app/common/adapter/NPMRegistry.ts 100.00% <100.00%> (ø)
app/common/adapter/binary/AbstractBinary.ts 94.17% <100.00%> (+0.11%) ⬆️
...pp/common/adapter/binary/ChromeForTestingBinary.ts 100.00% <100.00%> (+2.89%) ⬆️
app/common/adapter/binary/NodePreGypBinary.ts 98.69% <100.00%> (+<0.01%) ⬆️
app/common/adapter/binary/PlaywrightBinary.ts 99.26% <100.00%> (+0.03%) ⬆️
...on/adapter/changesStream/CnpmjsorgChangesStream.ts 100.00% <100.00%> (ø)
app/common/constants.ts 100.00% <100.00%> (ø)
... and 49 more

... and 3 files with indirect coverage changes

@fengmk2 fengmk2 merged commit 8e1f4ca into cnpm:master Nov 6, 2023
9 of 11 checks passed
fengmk2 pushed a commit that referenced this pull request Nov 6, 2023
@semantic-release-bot
Release 3.48.3
072e146 
[skip ci]

## [3.48.3](v3.48.2...v3.48.3) (2023-11-06)

### Bug Fixes

* es query script score syntax fix and add error handler for 404 error ([#607](#607)) ([8e1f4ca](8e1f4ca))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

@elrrrrrrr elrrrrrrr Awaiting requested review from elrrrrrrr

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search_phase_execution_exception
3 participants
@Beace @fengmk2 @elrrrrrrr