-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support allow scopes #3
Conversation
WalkthroughThe recent update introduces a scope to the whitelist in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (3)
README.md (3)
Line range hint
48-48
: Remove multiple consecutive blank lines to maintain clean and consistent formatting.
Line range hint
6-6
: Consider using Markdown to format the bare URL to improve readability and aesthetics.- [https://github.com/cnpm/unpkg-white-list/actions/workflows/nodejs.yml] + [CI](https://github.com/cnpm/unpkg-white-list/actions/workflows/nodejs.yml)
Line range hint
45-45
: Add alternate text to the image for better accessibility.- <img src="https://avatars.githubusercontent.com/u/156269?v=4" width="100px;"/> + <img src="https://avatars.githubusercontent.com/u/156269?v=4" width="100px;" alt="Contributor: fengmk2"/>
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- README.md (1 hunks)
- test/index.js (2 hunks)
Additional comments not posted (3)
README.md (1)
25-33
: The addition of theallowScopes
section clearly explains how to add scoped packages to the whitelist.test/index.js (2)
13-13
: Renamingcount
topackages
improves clarity by better reflecting what the variable represents.
30-40
: The new loop for iterating overpkg.allowScopes
is correctly implemented and includes comprehensive checks and assertions.
[skip ci] ## [1.2.0](v1.1.0...v1.2.0) (2024-05-18) ### Features * support allow scopes ([#3](#3)) ([6e1b821](6e1b821))
cnpm/cnpmcore#686
Summary by CodeRabbit
Documentation
@eggjs
to the allowed scopes.Tests