Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema for old signatures #65

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Add schema for old signatures #65

merged 2 commits into from
Jul 8, 2023

Conversation

tiltingpenguin
Copy link
Collaborator

This PR aims to add a schema for the old distro_signatures we still support in cobbler and also fix some issues in the schema like required values not being enforced

Fixes #63

@SchoolGuy SchoolGuy added this to the v1.0.0 milestone Jul 7, 2023
@SchoolGuy SchoolGuy self-requested a review July 7, 2023 20:18
@SchoolGuy
Copy link
Member

This PR will get a review from me however, @tiltingpenguin will also state his opinion about my changes. I will work on this PR this evening and he will take it back over tomorrow.

@SchoolGuy
Copy link
Member

The failing validations need to be now compared to the main repository and we need to decide what schema we would like to use in the end and what errors need to be fixed where. The schema MUST validate without errors against shipped versions of Cobbler.

@tiltingpenguin
Copy link
Collaborator Author

The validation error in the latest signatures comes from a typo in the signatures in cobbler.github.io which will be fixed by cobbler/cobbler.github.io#179

@SchoolGuy
Copy link
Member

@tiltingpenguin Could you please double-check check the changes I did to the mentioned PR yesterday? If that is done I would merge that one and then rerun the actions here.

@SchoolGuy SchoolGuy marked this pull request as ready for review July 8, 2023 11:49
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rerun the CI once the linked PR (cobbler/cobbler.github.io#179) is merged. After the CI is green we can merge this PR.

@SchoolGuy SchoolGuy merged commit e140643 into main Jul 8, 2023
10 checks passed
@SchoolGuy SchoolGuy deleted the schema-for-old-signatures branch July 8, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Provide a JSON Schema for older versions of Cobbler.
2 participants