-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema for old signatures #65
Conversation
fbd84d4
to
aea8d54
Compare
This PR will get a review from me however, @tiltingpenguin will also state his opinion about my changes. I will work on this PR this evening and he will take it back over tomorrow. |
87c391d
to
671fc22
Compare
552f31a
to
9bed545
Compare
b72214c
to
5c4d0b0
Compare
The failing validations need to be now compared to the main repository and we need to decide what schema we would like to use in the end and what errors need to be fixed where. The schema MUST validate without errors against shipped versions of Cobbler. |
The validation error in the latest signatures comes from a typo in the signatures in cobbler.github.io which will be fixed by cobbler/cobbler.github.io#179 |
@tiltingpenguin Could you please double-check check the changes I did to the mentioned PR yesterday? If that is done I would merge that one and then rerun the actions here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rerun the CI once the linked PR (cobbler/cobbler.github.io#179) is merged. After the CI is green we can merge this PR.
This PR aims to add a schema for the old distro_signatures we still support in cobbler and also fix some issues in the schema like required values not being enforced
Fixes #63