-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host signatures in this repo #66
Conversation
@tiltingpenguin GitHub pages are missing in the CI (I don't see how ONLY those two files are published) and furthermore, I had an idea that you can decide if you want to implement it or not... We could utilize the backport for Py 3.6 of importlib-resources to embed the JSON and schema in the library. That would enable us to prevent a requirement to the internet at least as a starting point. If we don't ship the JSON in Cobbler anymore that would mean the user would need to either have internet or create their own file from scratch. As most users are happy so far in Cobbler with the default I think this is a reasonable thing to do. |
9072f6e
to
15c9fcf
Compare
15c9fcf
to
dd01fe2
Compare
915535f
to
36261be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's hope that it works as expected. :)
This PR is a refactoring to be able to cleanly host all the versions of distro_signatures.json and their correlating schemas here in this repository on github pages.
Fixes: #57