Host signatures in this repo #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiltingpenguin
added
the
documentation
|
@tiltingpenguin GitHub pages are missing in the CI (I don't see how ONLY those two files are published) and furthermore, I had an idea that you can decide if you want to implement it or not... We could utilize the backport for Py 3.6 of importlib-resources to embed the JSON and schema in the library. That would enable us to prevent a requirement to the internet at least as a starting point. If we don't ship the JSON in Cobbler anymore that would mean the user would need to either have internet or create their own file from scratch. As most users are happy so far in Cobbler with the default I think this is a reasonable thing to do. |
tiltingpenguin
force-pushed
the
host-signatures
branch
from
9072f6e
to
15c9fcf
Compare
tiltingpenguin
force-pushed
the
host-signatures
branch
from
15c9fcf
to
dd01fe2
Compare
tiltingpenguin
force-pushed
the
host-signatures
branch
from
915535f
to
36261be
Compare
SchoolGuy
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring to be able to cleanly host all the versions of distro_signatures.json and their correlating schemas here in this repository on github pages.
Fixes: #57