Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fail CDP commands on unhandled exceptions #9639

Merged
merged 3 commits into from
Jul 27, 2018

Commits on Jul 21, 2018

  1. Configuration menu
    Copy the full SHA
    1a4d4ee View commit details
    Browse the repository at this point in the history
  2. test: Fail CDP commands on unhandled exceptions

    Install a Chrome Devtools Protocol handler for unhandled exceptions, and
    fail the next CDP command with it.  This got lost with the move from
    PhantomJS to Chrome.
    
    Some of our tests rely on failed ph_* function invocations, so we must
    not log failures of ph_wait_cond(); these  are also technically
    unhandled exceptions. So turn this into a proper `PhWaitCondTimeout`
    error class, so that it can be identified reliably.
    
    Handle cases where undefined value is passed to fail/success in
    cdp-driver.js.
    
    Adjust the naughty override for the XTerm.js crash (cockpit-project#9641) as this now
    shows the actual underlying crash instead of just the followup element
    wait timeout.
    
    Closes cockpit-project#9639
    martinpitt committed Jul 21, 2018
    Configuration menu
    Copy the full SHA
    8a574a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2018

  1. test: Ignore c3 data_types null crashes

    This gets triggered by the CPUUsage DonutChart in
    pkg/kubernetes/scripts/virtual-machines/components/VmMetricsTab.jsx.
    
    This seems to be some race condition when switching pages, which
    supposedly also means "(un)render in React". Cockpit code has no control
    over this, and it also does not break the user experience, so ignore the
    exception.
    
    See c3js/c3#2187 and simlilar issues
    bcbcarl/react-c3js#22 or
    c3js/c3#1205.
    martinpitt committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    6fb1ba7 View commit details
    Browse the repository at this point in the history