test: Robustify TestMachines.testCreate #9699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the checkOsOrVendorFiltered() function to not expect a wait_present() failure, and avoid catching blanket exceptions. Use `wait_not_present()` instead. Otherwise this unhandled exception from `ph_wait_cond()` bubbles up to the actual page, which is confusing when running the tests in an interactive browser for debugging.
|
This was originally a fix for #9639 while the code did not get along with unhandled exceptions from our own test suite. This isn't necessary any more, but I still think this is a nice little cleanup. |
|
This breaks, and I don't care enough, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the checkOsOrVendorFiltered() function to not expect a
wait_present() failure, and avoid catching blanket exceptions. Use
wait_not_present()instead.Otherwise this unhandled exception from
ph_wait_cond()bubbles up tothe actual page, which is confusing when running the tests in an
interactive browser for debugging.