Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse literals more like Postgres #1807

Merged
merged 2 commits into from
Jul 26, 2015
Merged

parse literals more like Postgres #1807

merged 2 commits into from
Jul 26, 2015

Commits on Jul 26, 2015

  1. parse literals more like Postgres 

    with this change

* rewrote SQL escaping. It'll output an escaped string when it has to, or when
  a single-quote or backslash appears (the former could be written as '', but
  this is more awkward to implement; the latter needs escaping only in an
  escaped string, which would require an extra pass through the string prior
  to beginning the encoding - not worth it).
* no escaping of "; Postgres doesn't do it
* dissect and update all the test cases affected by this and add some new ones.

found via go-fuzz, ping @dvyukov.
    @tbg
    tbg committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    07c3b0c View commit details
    Browse the repository at this point in the history

  2. disallow unsupported escapings

    @tbg
    tbg committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    c620ff6 View commit details
    Browse the repository at this point in the history