-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make categories optional in core config #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also consider having some prompt to create categories in place of the missing category sections in report.md
or stdout summary 🤔 But that's a different discussion and out of scope of this PR, I believe.
packages/cli/src/lib/implementation/core-config.integration.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/implementation/core-config.integration.test.ts
Outdated
Show resolved
Hide resolved
d712c32
to
02761cd
Compare
@matejchalk |
02761cd
to
f293555
Compare
f293555
to
068b1eb
Compare
068b1eb
to
aae11ed
Compare
Done ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could update the snippets in 'docs/custom-plugind.md'
Closes #407
I aimed for handling the optional categories only in the cli layer and maintained the existing data structure fully in reports. I just hide the sections for empty categories.
Follow-up by @Tlacenka:
undefined
and[]
by configuring categories schema to allow empty array.