-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-lighthouse): add audit details to lighthouse plugin #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit e214a03 with source commit 8d6dccb. 🏷️ Categories🗃️ Groups👍 2 groups improved
18 other groups are unchanged. 🛡️ Audits👍 9 audits improved, 👎 1 audit regressed, 8 audits changed without impacting score
491 other audits are unchanged. |
BioPhoton
commented
Jun 12, 2024
matejchalk
reviewed
Jun 13, 2024
packages/plugin-lighthouse/src/lib/runner/details/item-value.ts
Outdated
Show resolved
Hide resolved
packages/plugin-lighthouse/src/lib/runner/details/item-value.ts
Outdated
Show resolved
Hide resolved
packages/plugin-lighthouse/src/lib/runner/details/item-value.ts
Outdated
Show resolved
Hide resolved
packages/plugin-lighthouse/src/lib/runner/details/item-value.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/plugin-lighthouse/src/lib/runner/details/table.type.unit.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
matejchalk
previously approved these changes
Jun 17, 2024
# Conflicts: # packages/plugin-lighthouse/src/lib/runner/utils.ts # packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts
matejchalk
requested changes
Jun 20, 2024
matejchalk
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes logic to parse table data from lighthouse reports.
It includes:
ItemValue
datatable