feat(plugin-lighthouse): add audit details to lighthouse plugin #684

BioPhoton · 2024-05-28T21:05:30Z

This PR includes logic to parse table data from lighthouse reports.

It includes:

parsing and formatting of ItemValue data
parsing of details of type table
all test and test data to understand the logic

…d debug data

Co-authored-by: Matěj Chalk <[email protected]>

Co-authored-by: Katka Pilátová <[email protected]>

Co-authored-by: Matěj Chalk <[email protected]>

github-actions · 2024-06-12T18:09:15Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit e214a03 with source commit 8d6dccb.

🏷️ Categories

🏷️ Category	⭐ Current score	⭐ Previous score	🔄 Score change
Performance	🟡 58	🟡 51
Code coverage	🟡 89	🟡 89
Accessibility	🟢 100	🟢 100	–
Best Practices	🟢 100	🟢 100	–
SEO	🟡 85	🟡 85	–
Bug prevention	🟢 100	🟢 100	–
Code style	🟢 99	🟢 99	–
Security	🟢 100	🟢 100	–
Updates	🟡 79	🟡 79	–
Custom checks	🟡 67	🟡 67	–

🗃️ Groups

👍 2 groups improved

🔌 Plugin	🗃️ Group	⭐ Current score	⭐ Previous score	🔄 Score change
Lighthouse	Performance	🟡 58	🟡 51
Code coverage	Code coverage metrics	🟡 89	🟡 89

18 other groups are unchanged.

🛡️ Audits

👍 9 audits improved, 👎 1 audit regressed, 8 audits changed without impacting score

🔌 Plugin	🛡️ Audit	📏 Current value	📏 Previous value
Lighthouse	Total Blocking Time	🟥 1,100 ms	🟥 1,850 ms
Lighthouse	Speed Index	🟨 3.6 s	🟨 4.4 s
Lighthouse	Time to Interactive	🟨 3.9 s	🟨 5.0 s
Lighthouse	First Meaningful Paint	🟨 2.4 s	🟨 2.9 s
Lighthouse	First Contentful Paint	🟨 2.4 s	🟨 2.7 s
Lighthouse	Cumulative Layout Shift	🟨 0.199	🟨 0.172
Lighthouse	Largest Contentful Paint	🟨 3.0 s	🟨 3.3 s
Code coverage	Line coverage	🟩 92 %	🟩 91 %
Code coverage	Branch coverage	🟨 83 %	🟨 83 %
Code coverage	Function coverage	🟩 92 %	🟩 91 %
Lighthouse	Minimizes main-thread work	🟥 4.4 s	🟥 5.8 s
Lighthouse	Metrics	🟩 3939	🟩 5014
Lighthouse	JavaScript execution time	🟩 0.2 s	🟩 0.3 s
Lighthouse	Server Backend Latencies	🟩 60 ms	🟩 110 ms
Lighthouse	Avoids enormous network payloads	🟩 Total size was 432 KiB	🟩 Total size was 432 KiB
Lighthouse	Max Potential First Input Delay	🟥 700 ms	🟥 710 ms
Lighthouse	Uses efficient cache policy on static assets	🟨 11 resources found	🟨 11 resources found
Lighthouse	Initial server response time was short	🟩 Root document took 10 ms	🟩 Root document took 0 ms

491 other audits are unchanged.

packages/models/src/lib/implementation/schemas.ts

packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts

packages/plugin-lighthouse/src/lib/runner/utils.ts

packages/plugin-lighthouse/src/lib/runner/details/details.ts

packages/plugin-lighthouse/src/lib/runner/details/item-value.ts

packages/plugin-lighthouse/src/lib/runner/details/item-value.unit.test.ts

packages/plugin-lighthouse/src/lib/runner/details/table.type.unit.test.ts

Co-authored-by: Matěj Chalk <[email protected]>

# Conflicts: # packages/plugin-lighthouse/src/lib/runner/utils.ts # packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts

packages/plugin-lighthouse/src/lib/runner/details/details.ts

BioPhoton and others added 30 commits April 16, 2024 23:15

refactor(model): add table to audit details

f9173b0

refactor: adjust typing

6ff30b3

test(utils): adjust snapshots

e53c84a

test(utils): fix tests

b15ca5e

refactor(utils): fix lint

1ee2734

Update packages/core/src/lib/normalize.ts

edebbc6

Update packages/utils/src/lib/reports/md/table.ts

e95a295

feat(utils): don't send table data to portal

056d4f9

refactor(utils): adjust data transform

b23d051

feat(plugin-lighthouse): add detail support for table, opportunity an…

e8fc9bd

…d debug data

refactor(utils): format code

fa2f6d2

Update packages/models/src/lib/audit-output.ts

080e3ac

Co-authored-by: Matěj Chalk <[email protected]>

Update packages/utils/src/lib/reports/generate-md-report.ts

daee456

Co-authored-by: Matěj Chalk <[email protected]>

Update packages/utils/src/lib/reports/generate-md-report.unit.test.ts

5fdecdd

Co-authored-by: Katka Pilátová <[email protected]>

Update packages/utils/src/lib/reports/generate-md-report.unit.test.ts

420622c

Co-authored-by: Katka Pilátová <[email protected]>

Update packages/utils/src/lib/reports/generate-md-report.unit.test.ts

bd403f2

Co-authored-by: Katka Pilátová <[email protected]>

Update packages/utils/src/lib/reports/generate-md-report.unit.test.ts

6e00ec8

Co-authored-by: Katka Pilátová <[email protected]>

Update packages/utils/src/lib/reports/generate-md-report.unit.test.ts

9b34999

Co-authored-by: Katka Pilátová <[email protected]>

Update packages/utils/src/lib/reports/generate-md-report.ts

ad510f8

Co-authored-by: Katka Pilátová <[email protected]>

Update packages/utils/src/lib/reports/generate-md-report.ts

6dc82df

Co-authored-by: Katka Pilátová <[email protected]>

Update packages/models/src/lib/table.ts

128d25e

Co-authored-by: Matěj Chalk <[email protected]>

test(utils): add report tests

45643db

test(utils): adopt line breaks

b7c1022

refactor(utils): normalize report logic for NEW_LINE in reports

028ea6d

test(models): test audit output details for table

cb27d5f

fix(utils): show details only if issues are given

f860ab1

refactor(utils): format

d548ccb

refactor(utils): adjust typing

ad8a43c

test(utils): adjust snapshots

d5a3d26

test(utils): adjust test data

b860fb0

test(models): adjust table tests

14a7a19

BioPhoton marked this pull request as ready for review June 12, 2024 18:06

BioPhoton requested a review from Tlacenka as a code owner June 12, 2024 18:06

BioPhoton commented Jun 12, 2024

View reviewed changes

packages/models/src/lib/implementation/schemas.ts Show resolved Hide resolved

matejchalk reviewed Jun 13, 2024

View reviewed changes

BioPhoton and others added 6 commits June 13, 2024 20:48

Update packages/plugin-lighthouse/src/lib/runner/details/details.ts

e62c756

Co-authored-by: Matěj Chalk <[email protected]>

Update packages/models/src/lib/implementation/schemas.ts

52aaced

Co-authored-by: Matěj Chalk <[email protected]>

Update packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts

2ec6587

Co-authored-by: Matěj Chalk <[email protected]>

Update packages/plugin-lighthouse/src/lib/runner/details/item-value.ts

a5c51ca

Co-authored-by: Matěj Chalk <[email protected]>

Update packages/plugin-lighthouse/src/lib/runner/utils.ts

93f0ad1

Co-authored-by: Matěj Chalk <[email protected]>

fix lint

5d38b56

BioPhoton requested a review from matejchalk June 13, 2024 19:08

BioPhoton added 4 commits June 15, 2024 01:20

add tests

5b411a8

refactor(utils): adjust logic

f55ef09

refactor(utils): adjust logic

3985b1d

refactor(utils): adjust logic

18c8b85

BioPhoton removed the request for review from Tlacenka June 15, 2024 00:37

matejchalk previously approved these changes Jun 17, 2024

View reviewed changes

BioPhoton added 2 commits June 20, 2024 02:48

Merge branch 'main' into add-audit-details-to-lighthouse-plugin

3d9aab9

# Conflicts: # packages/plugin-lighthouse/src/lib/runner/utils.ts # packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts

merge master

05ddd88

BioPhoton dismissed matejchalk’s stale review via 05ddd88 June 20, 2024 00:50

BioPhoton requested a review from matejchalk June 20, 2024 01:16

matejchalk requested changes Jun 20, 2024

View reviewed changes

packages/plugin-lighthouse/src/lib/runner/details/details.ts Show resolved Hide resolved

fix merge

39ef8d6

BioPhoton requested a review from matejchalk June 20, 2024 11:54

matejchalk approved these changes Jun 20, 2024

View reviewed changes

Merge branch 'main' into add-audit-details-to-lighthouse-plugin

ef592b9

BioPhoton merged commit e19917f into main Jun 20, 2024
16 checks passed

BioPhoton deleted the add-audit-details-to-lighthouse-plugin branch June 20, 2024 12:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plugin-lighthouse): add audit details to lighthouse plugin #684

feat(plugin-lighthouse): add audit details to lighthouse plugin #684

BioPhoton commented May 28, 2024 •

edited

Loading

github-actions bot commented Jun 12, 2024 •

edited

Loading

feat(plugin-lighthouse): add audit details to lighthouse plugin #684

feat(plugin-lighthouse): add audit details to lighthouse plugin #684

Conversation

BioPhoton commented May 28, 2024 • edited Loading

github-actions bot commented Jun 12, 2024 • edited Loading

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

BioPhoton commented May 28, 2024 •

edited

Loading

github-actions bot commented Jun 12, 2024 •

edited

Loading