Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Abstraction of GenericDataset and DfDataset #101

Open
1 task done
aiakide opened this issue Dec 19, 2023 · 0 comments
Open
1 task done

[Feature]: Abstraction of GenericDataset and DfDataset #101

aiakide opened this issue Dec 19, 2023 · 0 comments
Labels
🌀 cleanup Related to code or repository cleanup 🔧 enhancement Requests for improvements or enhancements to existing features ✨ feature Requests or discussions about new features 🚨 high priority Needs immediate attention or urgent resolution 💡 idea Ideas or suggestions for future enhancements 📋 needs review Requires code or design review ♻️ refactoring Related to refactoring or restructuring code

Comments

@aiakide
Copy link
Collaborator

aiakide commented Dec 19, 2023

✏️ Problem Description

At the moment there is a KerasGenericDataset and a KerasDfDataset that implements GenericDataset or DfDataset.
This is because there are some customizations for Keras. If we use PyTorch in a future release, there are some PyTorch specific functions within the abstract GenericDataset or DfDataset. This should be fixed.PyTorch-specific

💡 Feature Request

Make GenericDataset and DfDataset more abstract and move PyTorch-specific functions to a corresponding PyTorch dataset.

I would prefer to move every framework-specific code inside a separate library.

🌍 Context

This makes it easier to make frame-specific changes in the right place.

🔍 Additional Information

No response

👍 Code of Conduct

  • I agree to follow this project's Code of Conduct
@aiakide aiakide added ✨ feature Requests or discussions about new features 🔧 enhancement Requests for improvements or enhancements to existing features 💡 idea Ideas or suggestions for future enhancements 🚨 high priority Needs immediate attention or urgent resolution 📋 needs review Requires code or design review 🌀 cleanup Related to code or repository cleanup ♻️ refactoring Related to refactoring or restructuring code labels Dec 19, 2023
aiakide added a commit that referenced this issue Dec 19, 2023
@aiakide
fix (Dataset): Make DfDataset and GenericDataset abstract (#101)
3d5745d
@aiakide aiakide mentioned this issue Dec 19, 2023
Merged
7 tasks
aiakide added a commit that referenced this issue Dec 19, 2023
@aiakide
fix (Dataset): Make DfDataset and GenericDataset abstract (#101)
fb45374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🌀 cleanup Related to code or repository cleanup 🔧 enhancement Requests for improvements or enhancements to existing features ✨ feature Requests or discussions about new features 🚨 high priority Needs immediate attention or urgent resolution 💡 idea Ideas or suggestions for future enhancements 📋 needs review Requires code or design review ♻️ refactoring Related to refactoring or restructuring code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aiakide