Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoided losing brackets in character constants #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Avoided losing brackets in character constants #3

wants to merge 3 commits into from

Conversation

vgkilin
Copy link

@vgkilin vgkilin commented Apr 12, 2023

This fix helps not to lose brackets in constants like:

|...+....1....+....2....+....3....+....4....+....5....+....6....+....7....+....8
     A                                  9  2'Constant(something)'

@worksofliam
Copy link
Collaborator

worksofliam commented Apr 12, 2023 •
edited
Loading

@vgkilin Any chance you can write a test for this?

edit: in this file: https://github.com/halcyon-tech/vscode-displayfile/blob/main/test/tests.js

@vgkilin
Added test for brackets in string.
b331863 
Some new material for other improvments.
@worksofliam worksofliam self-requested a review April 17, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worksofliam worksofliam Awaiting requested review from worksofliam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vgkilin @worksofliam