-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CCSID of deployed files to 1208 if needed #2015
Conversation
Signed-off-by: S. Julliand <[email protected]>
Signed-off-by: S. Julliand <[email protected]>
Signed-off-by: S. Julliand <[email protected]>
I have tested and this works! |
Is there a reason why this is targetting 2.11 instead of 2.10? |
@edmundreinhardt 2.10.0 is basically finalized and we only need to do doc changes now. |
Just a shame because this is important to supporting IFS deployment. We were hitting this quite a bit on our test IBM i machines. For Code for i to support local development on 7.3 for example, this is critical. It is a small PR and should hopefully not be a big risk. |
@edmundreinhardt I am going to test it today 😄 |
Tested on three systems and it works as expected. Good work @sebjulliand! |
Changes
Resolves #1995
On systems <= 7.3, the deployed files are created with a CCSID 819 (or at least different from 1208).
This PR checks (once per connection, during the first deployment - the check result is cached) if the CCSID needs to be set to 1208 after a successful deployment and runs the
setccsid
command if needed.How to test this PR
Here is a query to list files with CCSID != 1208:
This should be tested on two systems:
Fixing files CCSID...
Deployed files' CCSID set to 1208
Checklist