-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Keepalive interval login settings #2077
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand You are quick!!! 😉 I'll review it asap... |
@sebjulliand Code works as expected - but the setting does not prevent the disconnect, unfortunately... 😞 I'm not sure how or if we can fix #2069... would have thought the keepalive setting was the solution, but apparantly not... Maybe you should break this PR into two PR and isolate the other fix for private key path in its own PR? |
Signed-off-by: Seb Julliand <[email protected]>
@chrjorgensen absolutely. I removed the private key fix from here and put it there: #2082 |
@sebjulliand Great! I changed this PR to draft... when we find a solution we can continue here if necessary... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this PR is not very good. Please do more work to make it better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I said, not very good. Work on this more.
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 587bc38. |
@sebjulliand is this actually ready to be reviewed? |
@worksofliam welp, it was changed to draft since it doesn't seem to fix the original issue, even though the keepalive is adjusted (checkout @chrjorgensen comment above). |
@sebjulliand I suspect it's also related to the timeout as set by the OS. @chrjorgensen What do you see with |
Changes
Resolves #2074
This PR adds a new input to the Logins settings to let the user define a custom SSH
![image](https://private-user-images.githubusercontent.com/11096890/334047544-d72f2ede-d7d3-4a1b-b8d2-757d0807a3d0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3Mjk1ODIsIm5iZiI6MTcyNTcyOTI4MiwicGF0aCI6Ii8xMTA5Njg5MC8zMzQwNDc1NDQtZDcyZjJlZGUtZDdkMy00YTFiLWI4ZDItNzU3ZDA4MDdhM2QwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA3VDE3MTQ0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQyNTVmNzVkZDU5YmMwNTg2ZjQwODFhMzY1YzBhMzdlMjU2MDdlZjg4YjhlN2QxMGQwMmE1NDkzOTljYjE5OGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.aVm8GvS48tlXKR4bYw9ejLmZ9Ot8ZQ0zSVToHcQRRvc)
Keepalive interval
.How to test this PR
Set a breakpoint in src/api/IBMi.ts on line 126.
connectionObject.keepaliveInterval
field is set with the custom value.Checklist