Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes and enhancements to debugger support #2151

Merged
merged 10 commits into from
Jul 6, 2024

Conversation

sebjulliand
Copy link
Collaborator

@sebjulliand sebjulliand commented Jul 3, 2024

Changes

  • Do not perform Sanity Check (i.e. migration of certificate generated prior to v2.9) if current user doesn't have *ALLOBJ authority
  • Added a regenerate certificate action in debug service's right click menu
  • Moved open configuration action to debug service's right click menu
    image
  • Changed the logic of the method checking the debug service job status when it starts. It did not perform well on slow CPU and/or bad connection
  • Debug service details cache is now cleared when disconnecting instead of connecting. That clearing could happen after the IBM i Debugger view title was loaded when connecting, leading to the wring version being displayed when switching between connections.
  • IBM i debugger view loads slightly faster thanks to Promise.all
  • Added an Open output action on the error notification showed when the debug service fails to start. Clicking on it will load the job's QPRINT spooled file that contains the output from the service startup script.
    image
    image
  • Force usage of /QOpenSys/usr/bin/openssl to generate certificates

How to test this PR

  • Connect to an IBM i with debug PTF installed
  • Try to regenerate the service certificate
  • Try to stop and start the service; the success notification should show up only once
  • Restart the debug server and service to ensure the view still loads fine

Checklist

  • have tested my change

@sebjulliand sebjulliand added the debug Debug client issue (IBM) label Jul 3, 2024
@sebjulliand sebjulliand added this to the 2.12.0 milestone Jul 3, 2024
@sebjulliand sebjulliand self-assigned this Jul 3, 2024
@sebjulliand sebjulliand linked an issue Jul 4, 2024 that may be closed by this pull request
Signed-off-by: Seb Julliand <[email protected]>
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand LGTM - works as expected. 👍

@chrjorgensen chrjorgensen merged commit f4a7f5c into master Jul 6, 2024
1 check passed
@sebjulliand sebjulliand deleted the feature/moreDebuggerStuff branch July 8, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug client issue (IBM)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug Service Continues to Fail (Refer to issue #2110)
2 participants