Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more configuration options #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add more configuration options #63

wants to merge 2 commits into from

Conversation

gdb
Copy link

@gdb gdb commented Feb 28, 2015

This PR allows the user to:

  1. Bind a particular interface. This is useful both for security (so you don't expose your development server), and also lets you bind to 127.0.0.1 to prevent OSX from launching a warning dialog when your firewall's on. (I avoided this to retain backwards-compatibility, but the ideal default would be to bind to 127.0.0.1.)

  2. Choose a separate build and watch path. This is useful for many projects which nest their main packages inside of the repository.

@rasmusrygaard
Copy link

@codegangsta Any chance you would be willing to merge this? We've gotten a lot of great use out of gin, and the changes here should be backwards-compatible while adding support for additional use cases.

@spolu
Copy link

spolu commented Nov 29, 2015

@codegangsta any update on this? it has been pretty well tested, does not break the existing API and adds a must-have capability for many repos.

@ibash
Copy link
Collaborator

ibash commented Nov 8, 2016

Binding to a specific interface was just added with #88 -- if anyone wants to resolve conflicts I'd be happy to merge the second option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants