Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added package watcher to allow gin to listen to changes in packages #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theonejb
Copy link

@theonejb theonejb commented Mar 7, 2015

The package watcher looks at the package in the current working directory,
and parses the source code to find out the imports. It then figures out
which of those imports are outside of the GOROOT (and thus not part of the stdlib),
and uses fsnotify.v1 to listen to changes to files in all those packages.

This allows gin to; for example, reload the web server providing a web API to another
library that is not a subpackage of the web server.

The package watcher looks at the package in the current working directory,
and parses the source code to find out the imports. It then figures out
which of those imports are outside of the GOROOT (and thus not part of the stdlib),
and uses fsnotify.v1 to listen to changes to files in all those packages.

This allows gin to; for example, reload the web server providing a web API to another
library that is not a subpackage of the web server.
@theonejb
Copy link
Author

theonejb commented Mar 7, 2015

@codegangsta First of all, gin is an amazing package that has been very useful to be over the past few days while developing a web app in Go. However, I missed having one feature from Django/Python, which is that the server will reload automatically even when an external package that the app depends on is changed. Thus; for instance, I could change the code for a third party library, and the Django server would reload automatically.

I really think this can be useful to gin as well. Also, this is my first pull request ever, so I'm not sure of the right way to go about contributing to any open source project. Please let me know what the next steps in this might be, and if you'll consider merging this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant