Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Path in the Scanner API #226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link

@laeubi laeubi commented Nov 24, 2022

This would be a minimal change to move the API of Scanner to the Path API

This could be some kind of minimal change that could be merged as base for larger changes like:

@laeubi
Copy link
Author

laeubi commented Nov 24, 2022

@olamy could this be a first step?

@kwin
Copy link
Contributor

kwin commented Jan 5, 2023

Also look at apache/maven-shared-utils#54. IMHO we should only implement in one library....

@laeubi
Copy link
Author

laeubi commented Jan 5, 2023

Also look at apache/maven-shared-utils#54. IMHO we should only implement in one library....

The most notable thing I see is that it is two years old now and no progress at all...

@gnodet
Copy link
Member

gnodet commented May 16, 2023

I'm a bit skeptical about breaking the API and replacing the return type of the getBasedir().
A less problematic approach would be to provide a different method which would return a Path instead, or a new interface if we want to avoid having both File and Path in the same interface (the implementation could implement both interface, provided they use different names for the conflicting methods).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants