Add suppress_derive_clone struct attribute
#326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathstuf
force-pushed
the
suppress-clone-derive
branch
3 times, most recently
from
d30884a
to
3b55bb5
Compare
This attribute suppresses the default-generated `derive(Clone)`. This may be necessary where `derive(Clone)` copies constraints in an unsatisfiable way. See: https://smallcultfollowing.com/babysteps//blog/2022/04/12/implied-bounds-and-perfect-derive/ See: rust-lang/rust#26925 Fixes: colin-kiegel#325
mathstuf
force-pushed
the
suppress-clone-derive
branch
from
3b55bb5
to
1dd03d5
Compare
|
|
|
I ran into issues actually using this. It was easier to instead just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute suppresses the default-generated
derive(Clone). This may be necessary wherederive(Clone)copies constraints in an unsatisfiable way.See: https://smallcultfollowing.com/babysteps//blog/2022/04/12/implied-bounds-and-perfect-derive/
See: rust-lang/rust#26925
Fixes: #325
I tried running the
compile-failtests but couldn't seem to get them to appear when usingRUSTFLAGS='--cfg compiletests'even though it seemed like it was building the required dependencies. Let's see what GHA says…