Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentaton links broken: Example Builds #2659

Closed
hmf opened this issue Jul 14, 2023 · 5 comments · Fixed by #2667
Closed

Documentaton links broken: Example Builds #2659

hmf opened this issue Jul 14, 2023 · 5 comments · Fixed by #2667
Milestone

Comments

@hmf
Copy link

hmf commented Jul 14, 2023

All links to example build scripts in this section are broken.

@lefou
Copy link
Member

lefou commented Jul 14, 2023

This is due to the fact that you are looking at a snapshot build of the documentation, which assumes that snaphot is also published. But we currently do not publish all snapshots to avoid wasteful resource usage, but only some of them. While developing Mill 0.11 we changed our documentation generation process, and unfortunately, it currently can't produce a version for older versions greater than 0.11.0-M8, especially not for 0.11.0 and 0.11.1 (which is currently the latest stable release).

@lefou
Copy link
Member

lefou commented Jul 14, 2023

Maybe, we can add the example zips to the documentation resources itself instead of linking to the release pages.

@hmf
Copy link
Author

hmf commented Jul 14, 2023

@lefou No problem. I am rereading the documentation and just wanted to warn about this in case you were not aware. No need to add the examples sources. I found these easily enough via Github's file search.

BTW, in my opinion the latest documentation is very well laid out. Excellent work. Thank you to all who contributed.

@hmf hmf closed this as completed Jul 14, 2023
@lefou
Copy link
Member

lefou commented Jul 14, 2023

@hmf Thank you for the feedback! it's appreciated.

I think the links to the example builds for real-world projects are indeed invalid. The new location is example/thirdparty and the set of project also differs.

@lefou lefou reopened this Jul 14, 2023
@Huelse
Copy link

Huelse commented Jul 20, 2023

Hoping move the change log to a single file and add some of awesome demo codes may be helper?

lefou added a commit that referenced this issue Jul 20, 2023
Links were broken. Changed to include the generated asciidoc instead.

Fix #2659
@lefou lefou added this to the 0.11.2 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants