Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Scala.js 0.6 support and removed some deprecated API #2218

Merged
merged 7 commits into from
Jan 13, 2023

Conversation

lefou
Copy link
Member

@lefou lefou commented Dec 27, 2022

No description provided.

@lefou lefou force-pushed the drop-scalajs-06 branch 2 times, most recently from 1e7eaf6 to 1971373 Compare January 3, 2023 09:41
@lefou
Copy link
Member Author

lefou commented Jan 3, 2023

@lolgab Can you help out with the failing test?

The snapshot of the upickle repository is way to old now. We should probably replace it by a newer one.
@lefou lefou marked this pull request as ready for review January 12, 2023 21:15
@lefou lefou requested a review from lolgab January 12, 2023 21:15
Copy link
Member

@lolgab lolgab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lefou lefou merged commit e157bd2 into com-lihaoyi:main Jan 13, 2023
@lefou lefou deleted the drop-scalajs-06 branch January 13, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants