ghc-filesystem: use same config file name even before 1.5.2 #9383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indeed, before 1.5.2, no config file was generated upstream, it was just broken. So there is no reason to use a different config file name in conan generators. Therefore we use the same config file name to make things simpler and coherent.
toge
approved these changes
Feb 14, 2022
uilianries
approved these changes
Feb 15, 2022
ericLemanissier
approved these changes
Feb 15, 2022
SSE4
pushed a commit
to madebr/conan-center-index
that referenced
this pull request
Feb 21, 2022
… 1.5.2 Indeed, before 1.5.2, no config file was generated upstream, it was just broken. So there is no reason to use a different config file name in conan generators. Therefore we use the same config file name to make things simpler and coherent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 1.5.2, no config file was generated upstream, it was just broken: see gulrak/filesystem#93.
So there is no reason to use a different config file name if version is lower than 1.5.2 in conan generators like I did in #9238.
Therefore I propose to use the same config file name to make things simpler and coherent.
conan-center hook activated.