-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build installer on Docker #2
Conversation
LGTM for me. There is one remaining point that we can address later because it needs an upstream fix: conda-forge/docker-images#122 Once merged into |
We should wait on tagging a release and publishing it. |
Agreed, I should have just asked hadim to fork off my working branch. Don't know why I didn't think of that. |
…ly failing on aarch64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should comment out the power and x86 platforms.
Currently, there is an issue with |
For versioning, I think we should do it ourselves in the
Then the build script picks it up with |
Or so we're all good with channels? |
Yes, the channels are good. Does the installer use the conda version given |
oh no sorry, I misunderstood your question. |
Something like that at the beginning of the build script: CONDA_VERSION=$(git tag --points-at HEAD)
# example: CONDA_VERSION="4.7.11-0"
if [ -z "$CONDA_VERSION" ]
then
echo "***** No Conda version detected in git tag.*****"
else
CONDA_VERSION=$(echo $CONDA_VERSION | cut -d "-" -f 1)
echo "***** Conda version detected in git tag: $CONDA_VERSION *****"
echo "Install appropriate conda version."
conda install -y "conda=$CONDA_VERSION"
fi |
We should test it on |
and then we read it in build.sh? That would be simpler actually. |
I meant, reading from git version and then adding that version constraint to |
What do you think about setting the version in MINIFORGE_VERSION=$(cat Miniforge/construct.yaml | grep version | cut -d ":" -f 2)
CONDA_VERSION=$(echo $MINIFORGE_VERSION | cut -d "-" -f 1)
echo "***** Install conda version: $CONDA_VERSION *****"
conda install -y "conda=$CONDA_VERSION" |
Once in |
If we get the version from tags, it's weird because it's harder to update conda version from a PR. |
What I'm saying is you need, name: Miniforge
version: 4.7.11-0
channels:
- https://conda.anaconda.org/conda-forge
# This will continue to be a dependency until the compilers are
# moved to conda-forge.
- https://conda.anaconda.org/c4aarch64 [linux-aarch64]
write_condarc: True
license_file: ../LICENSE
specs:
- python >=3,<3.8
- conda 4.7.11
- pip Note the version on conda. |
Of course, it's even simpler that way :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Two small questions
This PR starts to be very long. After you've reviewed my last commits, I would like to merge this into |
I'm good with that |
@isuruf are you good if we merge this? |
First try.