-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to python 3.12 #603
Update to python 3.12 #603
Conversation
3bceb51
to
bddad0b
Compare
Signed-off-by: Marcel Bargull <[email protected]>
README.md
Outdated
| Windows | x86_64 | [Miniforge3-Windows-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Windows-x86_64.exe) | | ||
| OS | Architecture | Minimum Version | Download | | ||
| --------|-------------------------------|------------------|-----------| | ||
| Linux | x86_64 (amd64) | glibc >= 2.12 | [Miniforge3-Linux-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-x86_64.sh) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead, we can just go with 2.17 here, right?! We'll drop 2.12 in a week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just went with 2.17 -- otherwise, I'd expect this to get outdated quickly.
| Linux | ppc64le (POWER8/9) | glibc >= 2.17 | [Miniforge3-Linux-ppc64le](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-ppc64le.sh) | | ||
| OS X | x86_64 | macOS >= 10.13 | [Miniforge3-MacOSX-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-x86_64.sh) | | ||
| OS X | arm64 (Apple Silicon) `(***)` | macOS >= 11.0 | [Miniforge3-MacOSX-arm64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh) | | ||
| Windows | x86_64 | Windows >= 7 | [Miniforge3-Windows-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Windows-x86_64.exe) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isuruf, do you know if this is still accurate or do we have things that bump this to 10?
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
00b8307
to
eabae5e
Compare
Let's get some approvals from folks that can confirm that #598 (comment) is satisfied and merge/build this at the beginning/middle of the week to not cause downstream troubles over weekends. |
I would like to document the last known working version:
|
scripts/build.sh
Outdated
elif [[ "${TARGET_PLATFORM}" == linux-* ]]; then | ||
export CONDA_OVERRIDE_OSX=10.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elif [[ "${TARGET_PLATFORM}" == linux-* ]]; then | |
export CONDA_OVERRIDE_OSX=10.9 | |
elif [[ "${TARGET_PLATFORM}" == osx-64 ]]; then | |
export CONDA_OVERRIDE_OSX=10.9 | |
elif [[ "${TARGET_PLATFORM}" == osx-arm64 ]]; then | |
export CONDA_OVERRIDE_OSX=11.0 |
I'm fine with that change.
I generally makes sense to but the overrides in.
As for 10.9
concretely, I've also thought about doing that but didn't consider it too be of relevance -- what's the reasoning for going with that still (in light that we changed the default nearly 2 months ago)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was to see if this propagated. Apparently not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this does nothing, should we remove it entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does work; there was just a typo in the initial commit (linux-*
instead of osx-*
).
Even makes the PyPy builds fail -- haven't looked into why yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda=24.1.1
onward has dep pypy3.9 >=7.3.15
and that one has been built against 10.13 already.
So, we need target 10.13 for that one.
PyPy builds of conda>=24.1.1 depend on pypy3.9>=7.3.15 with the latter targeting macOS>=10.13.
Co-authored-by: Isuru Fernando <[email protected]>
I can't approve my own merge request, but looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Anything blocking the merge here? Should we just proceed? |
| Linux | aarch64 (arm64) `(**)` | glibc >= 2.17 | [Miniforge3-Linux-aarch64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-aarch64.sh) | | ||
| Linux | ppc64le (POWER8/9) | glibc >= 2.17 | [Miniforge3-Linux-ppc64le](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-ppc64le.sh) | | ||
| OS X | x86_64 | macOS >= 10.13 | [Miniforge3-MacOSX-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-x86_64.sh) | | ||
| OS X | arm64 (Apple Silicon) `(***)` | macOS >= 11.0 | [Miniforge3-MacOSX-arm64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| OS X | arm64 (Apple Silicon) `(***)` | macOS >= 11.0 | [Miniforge3-MacOSX-arm64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh) | | |
| OS X | arm64 (Apple Silicon) | macOS >= 11.0 | [Miniforge3-MacOSX-arm64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need that footnote?
(***)
Apple silicon builds are experimental and haven't had testing like the other platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have CI for macOS ARM
That said, maybe we can relax this note a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to this, but I think a new PR is warranted if we want to review the language around OSX + arm.
Lets start the builds for this as they take a while already.
Thanks for this! When can we expect a new release which includes this PR? |
We are blocked on you can for your CI purposes just create a new test environment with python 3.12. It will only cost about 100MB of downloads. |
Closes #598
Closes #604
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)