Add warnings to deprecate Mambaforge #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
requested changes
Jul 24, 2024
Miniforge3/mambaforge_deprecation.sh
Outdated
| echo "Future Miniforge releases will NOT build Mambaforge installers." | ||
| echo "We advise you switch to Miniforge at your earliest convenience." | ||
| echo "Sleeping for 30s..." | ||
| sleep 30 |
There was a problem hiding this comment.
We should probably make an announcement before we do this. When do it though, we should include the sleep for GHA as well.
There was a problem hiding this comment.
hmaarrfk
reviewed
Jul 24, 2024
.github/workflows/ci.yml
Outdated
| run: | | ||
| echo "!!!!!! Mambaforge is now deprecated !!!!!" > MAMBAFORGE_LICENSE.txt | ||
| echo "Future Miniforge releases will NOT build Mambaforge installers." >> MAMBAFORGE_LICENSE.txt | ||
| echo "We advise you switch to Miniforge at your earliest convenience." >> MAMBAFORGE_LICENSE.txt |
There was a problem hiding this comment.
oh man, Miniforge vs Miniforge3..... naming decisions that come back to haunt us!!!!
There was a problem hiding this comment.
Yea... And how it's Miniforge3 for CPython but just Miniforge for PyPy :P
jaimergp
commented
Jul 25, 2024
jaimergp
commented
Jul 25, 2024
|
I added now some dates between October and end of the year where the installer will refuse to proceed:
Up for discussion, of course, but the setup is there now. |
|
Maybe we add the dates to the news item? |
|
OK I added them. |
beckermr
approved these changes
Jul 25, 2024
hmaarrfk
reviewed
Jul 25, 2024
Co-authored-by: Mark Harfouche <[email protected]>
|
The announcement is published so I think this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes from #602.
I've added:
To be decided, which deprecation periods we offer:
exit 1if the time and date is part of the preprogrammed brownout windowsIdeally we print this information in these scary messages already.