-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warnings to deprecate Mambaforge #615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits.
Miniforge3/mambaforge_deprecation.sh
Outdated
echo "Future Miniforge releases will NOT build Mambaforge installers." | ||
echo "We advise you switch to Miniforge at your earliest convenience." | ||
echo "Sleeping for 30s..." | ||
sleep 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably make an announcement before we do this. When do it though, we should include the sleep for GHA as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/workflows/ci.yml
Outdated
run: | | ||
echo "!!!!!! Mambaforge is now deprecated !!!!!" > MAMBAFORGE_LICENSE.txt | ||
echo "Future Miniforge releases will NOT build Mambaforge installers." >> MAMBAFORGE_LICENSE.txt | ||
echo "We advise you switch to Miniforge at your earliest convenience." >> MAMBAFORGE_LICENSE.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh man, Miniforge vs Miniforge3..... naming decisions that come back to haunt us!!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea... And how it's Miniforge3 for CPython but just Miniforge for PyPy :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct!!!
I added now some dates between October and end of the year where the installer will refuse to proceed:
Up for discussion, of course, but the setup is there now. |
Maybe we add the dates to the news item? |
OK I added them. |
Co-authored-by: Mark Harfouche <[email protected]>
The announcement is published so I think this is good to go. |
Comes from #602.
I've added:
To be decided, which deprecation periods we offer:
exit 1
if the time and date is part of the preprogrammed brownout windowsIdeally we print this information in these scary messages already.