Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyOCCT conda-forge recipe #5937

Closed
wants to merge 11 commits into from
Closed

pyOCCT conda-forge recipe #5937

wants to merge 11 commits into from

Conversation

trelau
Copy link

@trelau trelau commented May 23, 2018

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyocct) and found some lint.

Here's what I've got...

For recipes/pyocct:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [17, 18, 23, 35, 36]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyocct) and found it was in an excellent condition.

@trelau trelau changed the title Initial commit for pyOCCT recipe pyOCCT conda-forge recipe May 23, 2018
@trelau
Copy link
Author

trelau commented May 23, 2018

@looooo any tips for this error? looks familiar to what you had...

https://travis-ci.org/conda-forge/staged-recipes/builds/382932177#L403

@looooo
Copy link
Contributor

looooo commented May 24, 2018

looks familiar. building on circle-ci or adding these line on top of the build.sh should work:

if [ `uname` = "Darwin" ]; then
    sed -i '' 's/Xcode-9.app/Xcode.app/g' $PREFIX/lib/cmake/opencascade/OpenCASCADEVisualizationTargets.cmake
fi

reference: conda-forge/smesh-feedstock#6 (comment)

I guess the circle-ci problem is to due missing setuptools build-dependency.

@trelau
Copy link
Author

trelau commented May 24, 2018

@looooo thanks. how do we build on Circle-CI only? it seems you're still using Travis-CI for SMESH? It wasn't obvious to me how OCCT was done using Circle-CI only.

@looooo
Copy link
Contributor

looooo commented May 24, 2018

@trelau I don't know if this is possible for staged recipes. maybe @isuruf knows if it is possible to build a staged recipe with circle-ci for osx.

@looooo
Copy link
Contributor

looooo commented Jul 9, 2018

@conda-forge-admin, please rerender

@jf---
Copy link

jf--- commented Sep 12, 2018

building on circle-ci or adding these line on top of the build.sh should work:

@looooo this was very helpful thx ( when building from ci/conda / pyOCCT )


Onto the next little hurdle: when building on osx TBB is linked, but not a dependency in meta.yaml.

In file included from ../src/BVH.cpp:44:
In file included from /Users/jelleferinga/miniconda3/conda-bld/pyocct_1536760976964/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/include/opencascade/BVH_DistanceField.hxx:146:
/Users/jelleferinga/miniconda3/conda-bld/pyocct_1536760976964/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/include/opencascade/BVH_DistanceField.lxx:27:12: fatal error: 'tbb/tbb.h' file not found
#include <tbb/tbb.h>
^~~~~~~~~~~

@looooo
Copy link
Contributor

looooo commented Sep 12, 2018

@jf--- it should be a run-dependency of occt:
https://github.com/conda-forge/occt-feedstock/blob/master/recipe/meta.yaml#L33

at least for occt7.3

@jf---
Copy link

jf--- commented Sep 12, 2018

thx @looooo , so meta.yaml of pyOCCT suggest OCCT 7.2.
The thing though was that I commented out DPTHREAD_INCLUDE_DIRS or DENABLE_SMESH in build.sh; my bad....

@trelau trelau closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants