Feature/more wallets #337
Feature/more wallets #337
Conversation
| signEthersMessage, | ||
| sendEthersTransaction, | ||
| switchEthersNetwork | ||
| } | ||
| } | ||
|
|
||
| function getBrowserProviders(ethereum: any) { |
There was a problem hiding this comment.
Refactoring this appears to have resolved the issue I was having (and Lido still appears to have) where attempting to open MetaMask would open CoinbaseWallet instead.
There was a problem hiding this comment.
Dealing with multiple libraries that pollute the window namespace is difficult. I share your frustration. What if we created our own object inside window which would include all providers, something like window.__casimirProviders. Then each time we load a new provider we would copy its content from window.ethereum to window.__casimirProviders.etheruem and delete it from window. This would require us to load the libraries in a different way than we are doing now.
window.__casimirProviders = {
provider1: okx,
provider2: ethereum,
provider3: anotherone
}
| signEthersMessage, | ||
| sendEthersTransaction, | ||
| switchEthersNetwork | ||
| } | ||
| } | ||
|
|
||
| function getBrowserProviders(ethereum: any) { |
There was a problem hiding this comment.
Dealing with multiple libraries that pollute the window namespace is difficult. I share your frustration. What if we created our own object inside window which would include all providers, something like window.__casimirProviders. Then each time we load a new provider we would copy its content from window.ethereum to window.__casimirProviders.etheruem and delete it from window. This would require us to load the libraries in a different way than we are doing now.
window.__casimirProviders = {
provider1: okx,
provider2: ethereum,
provider3: anotherone
}
|
Merging this in and closing it out. I will look into creating and injecting our own object in window instead of relying on the browser wallet's api which appear to be conflicting with each other. |
@shanejearley - Implemented TrustWallet, BraveWallet, and OkxWallet. In the process, made some good refactors to
connectWallet/loginflow (specifically the way I'm checking if an account exists prior to logging in, adding an account, or signing up) as well as refactored the API pattern I was using to get these accounts from backend (using GETs instead of POSTs per @hawyar's feedback).Other wallets I am looking into include Binance, Jaxx Liberty, My Ether Wallet, Exodus Wallet, and Atomic Wallet, but I think this is a good start for now and can circle back if we declare it a priority to add any or all of these wallets.
As an aside, I noticed OkxWallet does not play well with other browser wallet extensions. It seems to overwrite the
window.ethereumobject that is critical for the other browser wallet to function. This isn't something that's necessarily within our control and is not something users would experience uniquely within our app (i.e., if they're using OkxWallet, they're probably not using other browser providers because of this issue). We can still offer OkxWallet to the users who are using this and it may not cause an issue unique to our app, so perhaps there is nothing to fix here (for now).