Feature/connect auth #341
Merged
Feature/connect auth #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First I will review from a UX perspective. I will consolidate my comments into a list and send after the review. I'd appreciate if @hawyar arbitrates any feedback you disagree with. |
ccali11
requested changes
May 30, 2023
There was a problem hiding this comment.
User Interface Feedback
Looking great!
User Experience Feedback
- As a user, I would expect the "Select Provider" modal to completely change to a "Select Address" modal instead of having a dropdown above the providers.
- As a user, I would like a way of knowing that I'm confirmed signed up or logged in or that my address was added to my user account
- As a user, I would like a way of knowing if I'm currently logged in or not (this could possibly be solved with however we solve the above point about confirming user successfully signed up, logged in, or added an address to their user account)
- Small bug where after connecting a first wallet address (say with provider MetaMask), then when I go to select Ledger, for a moment the MetaMask address still shows
Code Feedback
- Looks like we can remove the feather library from
package.jsonif we're going to use cdn
ccali11
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected auth flow and fixed shifting on modal opening.