Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/eslint rules #457

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Update/eslint rules #457

merged 2 commits into from
Nov 6, 2023

Conversation

ccali11
Copy link
Contributor

@ccali11 ccali11 commented Nov 6, 2023

This PR should make development more efficient for all of us (format on save) and make the code more consistent and readable across our repo.

Updated rules to those that we converged on (although adjusted max-len to 150 instead of 120 for expediency for now; can readjust later). Feel free to suggest other rules you feel strongly about.

Also, the linting / formatting should be applied on save to make development easier. Please check your VSCode (or other IDE) User settings and Workspace settings to make sure they are not overwriting any of the linting / formatting.

Thanks, everyone, and please don't hesitate with any further questions/comments.

@shanejearley
Copy link
Contributor

What is the case for 150? I think you mentioned TS, but if other techniques are applied - max 2-3 arguments, precise but not extremely long type/interface names, return types - 120 seems like plenty. Maybe inline/in-parenthesis type assertions make function calls or conditonals long, but those can be rare and can also be moved to multiple lines (making a type assertion when setting a variable).

@shanejearley
Copy link
Contributor

I'm not ready to make any strong argument either but most style guides start at 80 and max out at 120.

@ccali11
Copy link
Contributor Author

ccali11 commented Nov 6, 2023

To minimize errors for now and so we can get this PR merged and get our IDEs on same page as soon as possible before a bunch of feature additions, improvements, updates, enhancements, bug fixes, etc.

@ccali11 ccali11 merged commit 15bf553 into develop Nov 6, 2023
1 check passed
@ccali11 ccali11 deleted the update/eslint-rules branch November 6, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants