Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make same changes as in fuzzyjoin to adapt to tidyr v1.0.0 #6

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Make same changes as in fuzzyjoin to adapt to tidyr v1.0.0 #6

merged 1 commit into from
Aug 6, 2019

Conversation

jennybc
Copy link
Contributor

@jennybc jennybc commented Aug 6, 2019

We are working towards a release of tidyr v1.0.0. tidyr::nest_() has been deprecated for a while and will become defunct in this release. This PR makes the same changes made in fuzzyjoin (dgrtwo/fuzzyjoin@a39fc46) to modify these calls. This code works with CRAN and dev tidyr.

tidygenomics will fail R CMD check until fuzzyjoin releases on CRAN, since there are calls to fuzzyjoin::genome_join() in the intro vignette. So it would make sense to submit to CRAN after fuzzyjoin but before tidyr.

@const-ae const-ae merged commit 655c44d into const-ae:master Aug 6, 2019
@const-ae
Copy link
Owner

const-ae commented Aug 6, 2019

I merged your changes, thank you very much Jenny for making the pull request.

I am not quite sure why do you think that R CMD check will fail. Is the interface of fuzzyjoin::genome_join() going to change? If it just that the internal calls of nest_() are replaced there shouldn't be any problems, right?

@jennybc
Copy link
Contributor Author

jennybc commented Aug 6, 2019

I am not quite sure why do you think that R CMD check will fail. Is the interface of fuzzyjoin::genome_join() going to change? If it just that the internal calls of nest_() are replaced there shouldn't be any problems, right?

Yeah, you're right. Your vignette would start failing if tidyr submits before fuzzyjoin. But hopefully the order will be the other way around.

@jennybc
Copy link
Contributor Author

jennybc commented Aug 6, 2019

And, to be clear, this implies that you can submit an update to CRAN at your earliest convenience.

@const-ae
Copy link
Owner

const-ae commented Aug 6, 2019

Great. Yes, I will try and see that I push an update to CRAN in the coming days :)

@const-ae
Copy link
Owner

const-ae commented Aug 8, 2019

@jennybc
Copy link
Contributor Author

jennybc commented Aug 8, 2019

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants