-
Notifications
You must be signed in to change notification settings - Fork 349
Remove dependencies on k8s.io/kubernetes #1463
Remove dependencies on k8s.io/kubernetes #1463
Conversation
Hi @dims. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall comment... will k8s not move the streaming package out, I thought it was scheduled for extraction?
This would be a big fork... lots to keep in sync when keps/fixes drop.
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright headers must be kept
@mikebrow yep. thinking aloud here by filing this WIP.
So the thought here is may be we should just create a repo here in containerd for things we need here to cut the cord to k8s.io/kubernetes. We may be able to convince folks in k/k to use that repo and drop the code from k/k. |
@mikebrow we may be able to get away with a separate go.mod file for integration, but that would not work well with |
if we go this way ... since it's an abrupt copy... we can paste our new headers above the old ones. |
That makes sense.. Thanks. Nice to have a wip PR even if only just for testing the process and getting closer to go mod while waiting for the k8s decision. Natives are getting very restless on this whole go mod thing. Personally I'm fine with vndr but I realize we are holding others up. |
true we can do a /tmp for integration.. |
@mikebrow going to see if i can push for something in k/k - please chime in on kubernetes/kubernetes#90552 |
@dims can we just split this up into multiples PRs... e.g. one for the integration/ dependencies on k8s namely kubelet/remote and kubelet/util..... Then we can tackle server/streaming hopefully by importing it from a common repo.. |
Ack @mikebrow will do soon hopefully in a few days |
2ac430e
to
24599d0
Compare
/test pull-cri-containerd-node-e2e |
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
24599d0
to
79a5297
Compare
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
79a5297
to
cbb7c28
Compare
Signed-off-by: Davanum Srinivas <[email protected]>
/test pull-cri-containerd-node-e2e |
/test pull-cri-containerd-node-e2e |
1 similar comment
/test pull-cri-containerd-node-e2e |
Added notes on how to copy stuff next time. |
Added notes on how to do this next time :) |
Some stats on what we pulled in:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is there going to be a follow up change here to reduce the scope of these moved libraries? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dmcgowan yes will poke at it as time permits. |
Break the link to k8s.io/kubernetes by copying some code over. We should only use public/versioned components from kubernetes (i.e, we should not depend on
k8s.io/kubernetes
as it is internal API subject to lots of changes)Notes on how to copy stuff next time:
doc.go
to drop the trailing comment in the package statements (that pin the package name to k8s.io/kubernetes)ltag -t "../project/script/validate/template" -v
to fix up the Copyright statements.golangci-lint run
to make sure there are no issues.