Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CR+LF instead of LF regardless of OS #103

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

kzys
Copy link
Member

@kzys kzys commented Feb 21, 2022

Git by default uses CR+LF on Windows, whereas gofmt always
uses LF even on Windows.

This commit lets Git uses LF on Windows.

Signed-off-by: Kazuyoshi Kato [email protected]

@kzys kzys force-pushed the fix-windows-lint branch 2 times, most recently from ba75399 to 2ed324a Compare February 21, 2022 21:13
@kzys kzys changed the title Use CR+LF instead of LF regardless of OSes Use CR+LF instead of LF regardless of OS Feb 21, 2022
@kzys
Copy link
Member Author

kzys commented Feb 21, 2022

Hmm, #104 shows that the Linters could be green without this change...

Git by default uses CR+LF on Windows, whereas gofmt always
uses LF even on Windows.

This commit lets Git uses LF on Windows.

Signed-off-by: Kazuyoshi Kato <[email protected]>
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit e35aa96 into containerd:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants