fix: improve type resolutions #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
refactor-resolvable-type-checks
branch
from
96a3306
to
7007946
Compare
legobeat
commented
Jul 31, 2024
legobeat
commented
Jul 31, 2024
legobeat
force-pushed
the
refactor-resolvable-type-checks
branch
from
9904196
to
4615d20
Compare
p12tic
reviewed
Aug 1, 2024
legobeat
force-pushed
the
refactor-resolvable-type-checks
branch
from
4615d20
to
c900d6d
Compare
legobeat
force-pushed
the
refactor-resolvable-type-checks
branch
2 times, most recently
from
77d9b42
to
0435a57
Compare
When support for python3.8 and python3.9 has been dropped, it will be possible to eat the cak and have it due to PEP-647. Signed-off-by: legobt <[email protected]>
Signed-off-by: legobt <[email protected]>
Signed-off-by: legobt <[email protected]>
Signed-off-by: legobt <[email protected]>
Signed-off-by: legobt <[email protected]>
legobeat
force-pushed
the
refactor-resolvable-type-checks
branch
from
0435a57
to
ea239c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running pyright yields many typing violations - some indicating actual issues and some due to lack of hints.
This does a minor refactor top remove a lot of the false-positive errors.
No user-facing changes in this PR. Actual bugfixes will be submitted as follow-ups after merge of this PR.