Minimum Python version 3.9 #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: legobt <[email protected]>
legobeat
force-pushed
the
drop-python-3.8
branch
from
b02ae7d
to
8411db4
Compare
Signed-off-by: legobt <[email protected]>
legobeat
force-pushed
the
drop-python-3.8
branch
from
1bed208
to
5610949
Compare
|
Agreed regarding upgrading to Python 3.9. Older distributions don't even have podman, so supporting older python is moot. If newer podman can be installed, then Python can be as well. Regarding dropping Python 3.9 I think let's wait until it's EOL itself. The benefits of typing are small to a tiny project like podman-compose. The downsides of some commercial customer of Red Hat being unable to upgrade to get a bugfix they need are larger. |
p12tic
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggesting to drop advertised support for Python 3.7 and 3.8, increasing minimum supported version to 3.9.
(I'd personally go as far as suggesting bumping as far as 3.10 or even 3.11 (Debian stable/Fedora 38) as the type annotation features there could be nice. Starting with this more conservative change to take the temperature on how conservative podman-compose intends to be wrt runtime backwards-compatibility :))