Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical dependency: the request of a dependency is an expression #1755

Closed
hoantran-it opened this issue Mar 1, 2024 · 7 comments · Fixed by #1758 · 4 remaining pull requests
Closed

Critical dependency: the request of a dependency is an expression #1755

hoantran-it opened this issue Mar 1, 2024 · 7 comments · Fixed by #1758 · 4 remaining pull requests
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@hoantran-it
Copy link

hoantran-it commented Mar 1, 2024

The latest update introduces this issue

WARNING in ./node_modules/react-player/lib/players/Mux.js 136:14-64
Critical dependency: the request of a dependency is an expression

Could we disable it?

@hemantgogia09
Copy link

seeing the same thing with 2.15.0

@luwes luwes added the bug Indicates an unexpected problem or unintended behavior label Mar 1, 2024
@luwes
Copy link
Collaborator

luwes commented Mar 1, 2024

which framework / build tool are you using?

@hemantgogia09
Copy link

hemantgogia09 commented Mar 1, 2024

This is some of the libraries that i think useful to know if you think i missed some important ones let me know

"react": "18.2.0",
"react-dom": "^18.2.0",

"eslint": "^8.56.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jsx-a11y": "^6.8.0",
"eslint-plugin-react": "^7.33.2",
"webpack": "^5.89.0",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^4.15.1"

@ps250551
Copy link

ps250551 commented Mar 1, 2024

We are seeing this as well, but only in our github runner
Screenshot 2024-03-01 at 4 39 10 PM

@hoantran-it
Copy link
Author

which framework / build tool are you using?

I'm using create-react-app

luwes added a commit that referenced this issue Mar 2, 2024
luwes added a commit that referenced this issue Mar 2, 2024
@luwes
Copy link
Collaborator

luwes commented Mar 2, 2024

should be fixed in v2.15.1. let me know otherwise!

@hoantran-it
Copy link
Author

should be fixed in v2.15.1. let me know otherwise!

awesome, thanks @luwes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment